Fix space available widget - ref #6719 #6896
Conversation
… it to the repository
There was a problem hiding this comment.
Files in src/CoreBundle/Migrations should not be modified in this PR. Please remove them or close this PR to open a new one without these.
See other change requests. Many small things to change, but overall a very good job code-wise (haven't tried running it yet).
| public function __invoke($cid): JsonResponse | ||
| { | ||
| $courseId = (int) $cid; | ||
| $sessionId = api_get_session_id(); |
There was a problem hiding this comment.
Use CidReqHelper::getSessionId() for $sessionId and CidReqHelper::getGroupId() for $groupId.
| return new JsonResponse(['error' => 'Course not found'], 404); | ||
| } | ||
|
|
||
| $sessionEntity = api_get_session_entity(); |
There was a problem hiding this comment.
Use CidReqHelper::getSessionEntity()
| } | ||
|
|
||
| // Path filtering - convert document.lib.php logic to Doctrine | ||
| if ('/' !== $path) { |
There was a problem hiding this comment.
This looks like the old files strategy of looking at file paths to define hierarchies. This is not the way this should be done in Chamilo 2.0. Rather, you should use ResourceFile and ResourceNode entities for that (ask if you need more details)
2 participants
Hi !
I refactored the code and implemented the space chart based on Chamilo v1.
I also added the ability to view other teachers’ spaces (it just felt right somehow).
I’m not sure if it works with groups, since I couldn’t find where to test that — hopefully someone can check! Theoretically, it should 😆
I hope my code is fine !
Issue : #6719
Screens :
If error :
(It is centered, I fixed it in the commit
Minor— I just took the screenshot before noticing it wasn’t.)